Add check for shadow dom root before closing submenu#93667
Closed
nrayburn-tech wants to merge 1 commit intomicrosoft:masterfrom
nrayburn-tech:shadowdompeek
Closed
Add check for shadow dom root before closing submenu#93667nrayburn-tech wants to merge 1 commit intomicrosoft:masterfrom nrayburn-tech:shadowdompeek
nrayburn-tech wants to merge 1 commit intomicrosoft:masterfrom
nrayburn-tech:shadowdompeek
Conversation
Member
|
@nrayburn-tech I was not able to merge this due to merge conflicts and the fork is gone. I will reference this PR in the commit |
Member
|
For endgame champion, Please ACK this PR |
Contributor
Author
|
No worries. Thanks for getting to it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cleaning up the submenu, a check is added for the shadow dom element. If it exist, then it checks the shadow dom ancestors.
This PR fixes #1809 in monaco-editor.