Feature #88480: Empty Lines Not Getting Commented-Out#93160
Merged
alexdima merged 6 commits intomicrosoft:masterfrom Jul 7, 2020
Merged
Feature #88480: Empty Lines Not Getting Commented-Out#93160alexdima merged 6 commits intomicrosoft:masterfrom
alexdima merged 6 commits intomicrosoft:masterfrom
Conversation
…eEmptyLines. Also added a test that doesn't work - to be fixed.
…st raised in microsoft#88480 with a new suite of tests based off original.
|
|
|
Are there any chances to be merged? It's a big pain, especially for those who use prettier for auto formatting that removes blank lines between comments. |
Contributor
Author
|
@n4nn31355 new CI tests failed. Going to fix it asap and then mention the assignee in the PR to get it pushed. |
Member
|
Thank you! |
|
@alvintangz Many thanks to you and the VS Code team for implementing this much-requested feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #88480
New setting editor.comments.includeEmptyLines allows you to include empty lines when adding or toggling single-line comments. Default behaviour does not allow for that to happen.
Acceptance test:
Tests provided.
Feel free to give suggestions. Cheers