Add a toolbar with some basic actions#92593
Merged
rebornix merged 5 commits intorebornix/notebookfrom Mar 16, 2020
Merged
Conversation
roblourens
force-pushed
the
roblou/addToolbar
branch
from
6079d14 to
7a11b86
Compare
roblourens
force-pushed
the
roblou/addToolbar
branch
from
4930d42 to
ce863ce
Compare
rebornix
reviewed
Mar 16, 2020
Member
rebornix
left a comment
rebornix
left a comment
There was a problem hiding this comment.
Good work! I ran it locally and it works pretty good. The only issue I ran into is cell height after resizing
The reason that happens is we will resize current element when there is internal size change, and that part of code doesn't include editor toolbar height.
I can make changes in upstream first to add some abstraction to cell height calculations and then update your branch accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple ways to do this and I am not sure what the best recommended modern method is but I register the command+keybinding with Action2, and create a MenuItemAction (Action tied to a command ID) for each, which is used for the toolbar/contextmenu.