Merged
Conversation
Member
not sure why you mean by that? Do you have two listeners and one modifies the event object? |
Member
|
Oh, I see - you trigger event while processing them... Can you pls add you test to this PR |
Contributor
Author
Member
There was a problem hiding this comment.
since this test is async (setTimeout) you must add the done parameter and call it. Alternatively make this test return a promise.
Contributor
Author
Member
|
yeah - looks good. waiting for the builds to finish |
Member
|
@f111fei - sorry we had some hiccups today. Can you rebase with master and try again? |
Contributor
Author
|
@jrieken I do as you say but I'm not sure if I'm right. |
Member
|
LGTM - thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debounceEventis abnormal sometimes.Steps to Reproduce:
Here is my test case:
event.test.ts.scripts\test.Here is error:
was not expecting keys.Reason:
Some code is changing
outputduringemitter.fireSolution:
Reset
outputbeforeemitter.fire