Fix sensitivity not always being applied.#9005
Conversation
|
@iclanzan, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alexandrudima and @bpasero to be potential reviewers |
|
Hi @iclanzan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
👍 Nice catch! Thank you for the contribution! |
| if (this._options.flipAxes) { | ||
| deltaY = e.deltaX; | ||
| deltaX = e.deltaY; | ||
| deltaY = deltaX; |
There was a problem hiding this comment.
Sorry if I'm missing something, but how does this work?
deltaY = deltaX;
deltaX = deltaY;
will not actually swap the two variables, it will just assign them both to have the value of deltaX. Is that the desired behavior?
My guess is you'd want to use [deltaY, deltaX] = [deltaX, deltaY]
There was a problem hiding this comment.
You are correct. Feel free to open a PR.
5 participants
Minor change to allow scroll sensitivity to be taken into account when options
flipAxesorscrollYToXare being used.