Skip to content

Fix extension install when drop into code#8786

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
f111fei:patch-10
Jul 11, 2016
Merged

Fix extension install when drop into code#8786
joaomoreno merged 1 commit intomicrosoft:masterfrom
f111fei:patch-10

Conversation

@f111fei
Copy link
Copy Markdown
Contributor

@f111fei f111fei commented Jul 6, 2016

this.extensionManagementService.install(extPath) return void now.

@mention-bot
Copy link
Copy Markdown

@f111fei, thanks for your PR! By analyzing the annotation information on this pull request, we identified @joaomoreno and @egamma to be potential reviewers

@f111fei
Copy link
Copy Markdown
Contributor Author

f111fei commented Jul 6, 2016

I think the interface function install in IExtensionManagementService return TPromise<IExtensionManifest> is better than TPromise<void>

@bpasero
Copy link
Copy Markdown
Member

bpasero commented Jul 6, 2016

@joaomoreno @isidorn please take a look

@joaomoreno joaomoreno added this to the July 2016 milestone Jul 6, 2016
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Jul 6, 2016
@jens1o
Copy link
Copy Markdown
Contributor

jens1o commented Jul 6, 2016

Please add the variable to the Success Message, which extension actually was installed.

@f111fei
Copy link
Copy Markdown
Contributor Author

f111fei commented Jul 7, 2016

@jens1o At the moment, install return a void Promise, it's hard to get which extension actually was installed.

@joaomoreno joaomoreno merged commit 5725826 into microsoft:master Jul 11, 2016
@joaomoreno
Copy link
Copy Markdown
Member

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants