Skip to content

Add Selection To Previous Find Match#8677

Merged
alexdima merged 1 commit intomicrosoft:masterfrom
yisibl:addSelectionToPreviousFindMatch
Jul 5, 2016
Merged

Add Selection To Previous Find Match#8677
alexdima merged 1 commit intomicrosoft:masterfrom
yisibl:addSelectionToPreviousFindMatch

Conversation

@yisibl
Copy link
Copy Markdown
Contributor

@yisibl yisibl commented Jul 2, 2016

demo

The shortcut keys is Ctrl/Cmd + Y.

But I want to use Ctrl/Cmd + E will be better, because the E in the upper left of the D.

Now the shortcut keys have too many duplicates.

{ "key": "cmd+e",                 "command": "workbench.action.quickOpen" },
{ "key": "cmd+p",                 "command": "workbench.action.quickOpen" },
{ "key": "ctrl+tab",              "command": "workbench.action.quickOpenNavigateNext",
                                     "when": "inQuickOpen" },
{ "key": "cmd+e",                 "command": "workbench.action.quickOpenNavigateNext",
                                     "when": "inQuickOpen" },
{ "key": "cmd+p",                 "command": "workbench.action.quickOpenNavigateNext",
                                     "when": "inQuickOpen" },

@mention-bot
Copy link
Copy Markdown

@yisibl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alexandrudima and @egamma to be potential reviewers

@msftclas
Copy link
Copy Markdown

msftclas commented Jul 2, 2016

Hi @yisibl, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@alexdima alexdima merged commit 3e7af1b into microsoft:master Jul 5, 2016
@alexdima
Copy link
Copy Markdown
Member

alexdima commented Jul 5, 2016

Thank you! Looks good!

alexdima added a commit that referenced this pull request Jul 5, 2016
@alexdima
Copy link
Copy Markdown
Member

alexdima commented Jul 5, 2016

I have made two tweaks:

  • merged nextMatch and previousMatch in one field since they cover the same case and would always be equal
  • removed the default keybindings, users can still easily write keybinding rules for them

@alexdima alexdima added this to the July 2016 milestone Jul 5, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
@yisibl yisibl deleted the addSelectionToPreviousFindMatch branch July 1, 2022 04:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants