Skip to content

Remove .pp from Ruby extension list. Issue #5366#8637

Merged
aeschli merged 1 commit intomicrosoft:masterfrom
dhollinger:master
Jul 25, 2016
Merged

Remove .pp from Ruby extension list. Issue #5366#8637
aeschli merged 1 commit intomicrosoft:masterfrom
dhollinger:master

Conversation

@dhollinger
Copy link
Copy Markdown

The *.pp file extension as it pertains it Ruby is actually
a file type used to denote a Puppet Manifest written in the Puppet
DSL (which itself is written in Ruby). The affected setting was
overriding VSCode Puppet extensions that are expecting the .pp
extension to be detected as file type Puppet.

The *.pp file extension as it pertains it Ruby is actually
a file type used to denote a Puppet Manifest written in the Puppet
DSL (which itself is written in Ruby). The affected setting was
overriding VSCode Puppet extensions that are expecting the .pp
extension to be detected as file type Puppet.
@mention-bot
Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @Ikuyadeu and @egamma to be potential reviewers

@msftclas
Copy link
Copy Markdown

msftclas commented Jul 1, 2016

Hi @dhollinger, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@aeschli aeschli merged commit af595e4 into microsoft:master Jul 25, 2016
@aeschli
Copy link
Copy Markdown
Contributor

aeschli commented Jul 25, 2016

Thanks @dhollinger !

@aeschli aeschli added this to the July 2016 milestone Jul 25, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants