Make terminal link behavior consistent with the editor#83620
Merged
Tyriar merged 8 commits intomicrosoft:masterfrom Dec 31, 2019
Merged
Make terminal link behavior consistent with the editor#83620Tyriar merged 8 commits intomicrosoft:masterfrom
Tyriar merged 8 commits intomicrosoft:masterfrom
Conversation
jmbockhorst
changed the title
jmbockhorst
changed the title
founderio
reviewed
Dec 30, 2019
src/vs/workbench/contrib/terminal/browser/terminalLinkHandler.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Dec 31, 2019
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Thanks, I made some small tweaks but works good.
The main difference now is when you mouse onto the tooltip and then back onto the link in the editor it doesn't hide but in the terminal is hides and displays a new one.
src/vs/workbench/contrib/terminal/browser/terminalWidgetManager.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the terminal links behavior like the editor. The hover tooltip now has a "Follow Link" link like the editor links. Fixes #77964. Related: #78647.
@Tyriar I set the timeout to 50ms for the leave tooltip and it seems to work reliably for me, but it may need to be tweaked. I also had to allow pointer event on the widget overlay so the widget could receive mouse events, but I'm not sure if this will break anything else.