Skip to content

Filter out dead keys in tree keyboard navigation#82972

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
frobinsonj:fix-80741
Oct 21, 2019
Merged

Filter out dead keys in tree keyboard navigation#82972
joaomoreno merged 1 commit intomicrosoft:masterfrom
frobinsonj:fix-80741

Conversation

@frobinsonj
Copy link
Contributor

Fixes #80741

Steps to reproduce original issue:

  1. Set keyboard layout to Portuguese
  2. Put focus on explorer section
  3. Press one of the following keys:
  • ^
  • ´
  • `
  • ~

This PR should prevent these key presses from outputting 'Dead' in the tree keyboard navigation.

@joaomoreno joaomoreno merged commit cfb88f2 into microsoft:master Oct 21, 2019
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 21, 2019
@joaomoreno joaomoreno added the tree-widget Tree widget issues label Oct 21, 2019
@frobinsonj frobinsonj deleted the fix-80741 branch October 22, 2019 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tree-widget Tree widget issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Press BracketLeft to find in explorer and shows Dead

2 participants