Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks #82757
Merged
alexr00 merged 6 commits intomicrosoft:masterfrom Oct 21, 2019
Merged
Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks #82757alexr00 merged 6 commits intomicrosoft:masterfrom
alexr00 merged 6 commits intomicrosoft:masterfrom
Conversation
hypercubestart
changed the title
alexr00
requested changes
Oct 18, 2019
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a few changes then we'll be good to go.
src/vs/workbench/contrib/quickopen/browser/quickopen.contribution.ts
Outdated
Show resolved
Hide resolved
hypercubestart
force-pushed
the
fix-30419
branch
from
edfc774 to
cdb6d34
Compare
Contributor
Author
|
@alexr00 Can you please review this PR again? Thank you! |
alexr00
approved these changes
Oct 21, 2019
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Looks good, thank you for taking on this change and finishing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #30419 and #80649
This creates a new setting section called
quickOpenunderFeaturesand allows the user to specify the number of recent tasks in the quick open history to keep track of.Not sure if it was a good idea to add a default parameter to the LRUCache
setmethod, but it was the cleanest and quickest way to keep the ordering of the quick open tasks from most recent - least recent while using an LRUCache.