Skip to content

Feature/pin close others#82545

Merged
bpasero merged 2 commits intomicrosoft:masterfrom
tegandbiscuits:feature/pin-close-others
Oct 15, 2019
Merged

Feature/pin close others#82545
bpasero merged 2 commits intomicrosoft:masterfrom
tegandbiscuits:feature/pin-close-others

Conversation

@tegandbiscuits
Copy link

Currently when someone selects 'Close Others' on an unpinned editor, the editor remains unpinned.

That behavior seemed inconsistent to me since moving an editor around in a group or to a new group pins it. I think it makes sense that if someone is saying to close all editors apart from one, that the one editor should be pinned.

I also made it so an editor is pinned if someone selects 'Close to the right', but I'm less sure of that behavior. If this behavior remains, does it make sense to pin any unpinned editors to the left?

I don't have a problem adding tests, but I didn't see where the relevant tests were.

Here's the new behavior
close others vscode

@bpasero bpasero merged commit 11daba9 into microsoft:master Oct 15, 2019
@bpasero
Copy link
Member

bpasero commented Oct 15, 2019

makes sense 👍

@bpasero bpasero added this to the October 2019 milestone Oct 15, 2019
@tegandbiscuits tegandbiscuits deleted the feature/pin-close-others branch October 15, 2019 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants