Fix #82200 - "Preserve Case" button in search viewlet is not tabbable#82485
Merged
roblourens merged 3 commits intomicrosoft:masterfrom Oct 23, 2019
Merged
Fix #82200 - "Preserve Case" button in search viewlet is not tabbable#82485roblourens merged 3 commits intomicrosoft:masterfrom
roblourens merged 3 commits intomicrosoft:masterfrom
Conversation
roblourens
requested changes
Oct 15, 2019
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Great, except tabbing backwards (shift+tab) needs to work too.
Contributor
Author
|
@roblourens , Sorry forgot to add that part but it is taken care now , Please check :) |
Member
|
Ok now if the replace input is collapsed, I can't shift+tab past the details |
Contributor
Author
|
@roblourens . Fixed this and sorry for the delay :) |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roblourens , Added the tab functionality for the preserve case button in order to fix #82200.
Whatever
onRegexKeyDownwas doing before is now being done inonPreserveCaseKeyDownandonRegexKeyDownonly makes the preserve case to get focussed.