Skip to content

Fix #82199, resetting some color of code blocks at Markdown Preview with light theme#82453

Merged
mjbvz merged 6 commits intomasterfrom
unknown repository
Oct 15, 2019
Merged

Fix #82199, resetting some color of code blocks at Markdown Preview with light theme#82453
mjbvz merged 6 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Oct 13, 2019

This PR fixes #82199, which is opened by myself, that resets color theme of number, title and built_in in code blocks at Preview with light theme, so that they can be easier to read.

Resetting Before
before

Resetting After
fixe

ganxy1028 added 2 commits October 13, 2019 17:21
This PR resets color theme of number, title and built_in at Preview with light theme.
@ghost ghost changed the title Fix #82199 hard to read numbers in code blocks at markdown preview with light theme Fix #82199 hard to distinguish numbers in code blocks at markdown preview with light theme Oct 13, 2019
@ghost ghost changed the title Fix #82199 hard to distinguish numbers in code blocks at markdown preview with light theme Fix #82199, reset some color of code blocks at Markdown Preview with light theme Oct 13, 2019
@ghost ghost changed the title Fix #82199, reset some color of code blocks at Markdown Preview with light theme Fix #82199, resetting some color of code blocks at Markdown Preview with light theme Oct 13, 2019
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good overall, just remove the owner comment. Thanks

I already merged #82450 since it came in first and fixed the problem in a scoped way

Visual Studio-like style based on original C# coloring by Jason Diamond <[email protected]>

*/
/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No owner comments please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove done

@ghost ghost requested a review from mjbvz October 15, 2019 00:34
@mjbvz mjbvz merged commit 5c705ea into microsoft:master Oct 15, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 15, 2019

Thanks! Will be in next insiders build and is scheduled to go out with VS Code 1.40

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown: color of numbers in code blocks is not suitable with light theme at Preview

1 participant