Skip to content

Fixed the problem of overwriting many characters in suggestion#82349

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
yamachu:fix/suggest-over-remove
Oct 11, 2019
Merged

Fixed the problem of overwriting many characters in suggestion#82349
joaomoreno merged 1 commit intomicrosoft:masterfrom
yamachu:fix/suggest-over-remove

Conversation

@yamachu
Copy link
Contributor

@yamachu yamachu commented Oct 11, 2019

This PR fixes #82324

No test code...

vscode-fix

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 11, 2019
@joaomoreno joaomoreno added the suggest IntelliSense, Auto Complete label Oct 11, 2019
@joaomoreno joaomoreno self-requested a review October 11, 2019 14:39
@joaomoreno
Copy link
Member

This looks like the right fix for me. It seems to have been an oversight by @jrieken in fcd4e09 to switch from editorPosition to position.

@jrieken When I test the PR, everything seems to work OK so I'll merge it such that we get the fix early Monday morning.

@joaomoreno joaomoreno merged commit a698117 into microsoft:master Oct 11, 2019
@jrieken
Copy link
Member

jrieken commented Oct 14, 2019

Thanks everyone

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

suggest IntelliSense, Auto Complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When we use auto-complete, text where after cursor will be removed

3 participants