Skip to content

fix image preview to show correct canvas size#82027

Merged
mjbvz merged 2 commits intomicrosoft:masterfrom
u-ways:master
Oct 7, 2019
Merged

fix image preview to show correct canvas size#82027
mjbvz merged 2 commits intomicrosoft:masterfrom
u-ways:master

Conversation

@u-ways
Copy link
Contributor

@u-ways u-ways commented Oct 6, 2019

The image preview used to show incorrect canvas size when the editor is scaled down vertically

See issue #81878

diff --git a/extensions/image-preview/media/main.css b/extensions/image-preview/media/main.css
index 913d2b4672..0f50cef683 100644
--- a/extensions/image-preview/media/main.css
+++ b/extensions/image-preview/media/main.css
@@ -4,8 +4,8 @@
  *--------------------------------------------------------------------------------------------*/
 
 html, body {
+       width: 100%;
        height: 100%;
-       max-height: 100%;
        text-align: center;
 }

@mjbvz mjbvz added this to the October 2019 milestone Oct 7, 2019
@mjbvz mjbvz merged commit 095358e into microsoft:master Oct 7, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 7, 2019

Thanks! This came in a bit too late for the September release but will in the first VS Code 1.40 insiders and is scheduled to go out with the October release

@mjbvz mjbvz mentioned this pull request Oct 7, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mjbvz mjbvz

Labels

None yet

Projects

None yet

Milestone

October 2019

Development

Successfully merging this pull request may close these issues.

2 participants

@u-ways @mjbvz