Use yarn compile for start scripts#81840
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Oct 7, 2019
Merged
Conversation
Tyriar
reviewed
Oct 2, 2019
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
@joaomoreno any reason we're not running npm run compile in these scripts?
Contributor
Author
|
@Tyriar This is a very helpful comment, thank you! 👍 I also thought about it but did not find any direct usages of |
Member
|
Just never been adopted. I suggest to use that instead. 👍 |
kondratyev-nv
changed the title
Contributor
Author
|
@Tyriar @joaomoreno I've fixed it, can you have a look? |
Member
|
Actually since we are |
kondratyev-nv
changed the title
Tyriar
approved these changes
Oct 3, 2019
Member
|
Thanks! 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building and running Code by steps in contributing guide causes
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memoryerror on compiling step. However, compiling with npm run compile works fine. This is because the compile script from package.json hasmax_old_space_size argument set.This PR adds the same argument to the compile step in scripts.