Fix 81779 Preserve Case Hyphen and Underscore replacement issues #81781
Merged
roblourens merged 3 commits intomicrosoft:masterfrom Oct 1, 2019
Merged
Fix 81779 Preserve Case Hyphen and Underscore replacement issues #81781roblourens merged 3 commits intomicrosoft:masterfrom
roblourens merged 3 commits intomicrosoft:masterfrom
Conversation
roblourens
reviewed
Oct 1, 2019
| @@ -7,20 +7,19 @@ import * as strings from './strings'; | |||
|
|
|||
| export function buildReplaceStringWithCasePreserved(matches: string[] | null, pattern: string): string { | |||
Member
There was a problem hiding this comment.
I don't understand why this function takes a string[] then only looks at the first element?
Contributor
Author
There was a problem hiding this comment.
The initial implementation was like this only , I guess it was some parameter passing issue ( Needed to send a string[] , We can fix it at the source and change the type here)
I am not sure about this , I can look it in detail and change it if required .
PS : I can raise one more issue to fix this parameter confusion.
roblourens
approved these changes
Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roblourens , This fixes #81779 .
I have changed the ordering of condition checking ( first we check for hyphen and underscore variables so that we don't return initially itself and miss replace foo_Bar to newfoo_newbar )
CC : @ArturoDent , This fixes the comment you had raised.