Skip to content

New cursor animation styles implemented#8153

Merged
alexdima merged 1 commit intomicrosoft:masterfrom
kisstkondoros:cursorstyles
Jul 6, 2016
Merged

New cursor animation styles implemented#8153
alexdima merged 1 commit intomicrosoft:masterfrom
kisstkondoros:cursorstyles

Conversation

@kisstkondoros
Copy link
Copy Markdown
Contributor

These are 'blink', 'smooth', 'phase', 'expand' and 'solid'.

Resolves #7923

These are 'blink', 'smooth', 'phase', 'expand' and 'solid'.

Resolves microsoft#7923
@mention-bot
Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @egamma and @alexandrudima to be potential reviewers

@alexdima alexdima merged commit c58e164 into microsoft:master Jul 6, 2016
alexdima added a commit that referenced this pull request Jul 6, 2016
New cursor animation styles implemented
@alexdima alexdima added this to the July 2016 milestone Jul 6, 2016
@alexdima
Copy link
Copy Markdown
Member

alexdima commented Jul 6, 2016

@kisstkondoros Thank you! ❤️

I was thinking of converting that to a CSS animation too. I just needed to do a few tweaks to your otherwise great PR (hope you don't mind!):

  • merged new option into the old cursorBlinking option (supporting visible from the old option but no longer supporting hidden)
  • added a fallback case for IE9 (where animations are not supported AFAIK)
  • tweaked the blink animation to get as far as I can tell 100% the same behaviour as before.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Idea] Cursor animations

4 participants