Fire onDidChangeReplElements directly from ReplModel#81392
Merged
isidorn merged 1 commit intomicrosoft:masterfrom Sep 26, 2019
Merged
Fire onDidChangeReplElements directly from ReplModel#81392isidorn merged 1 commit intomicrosoft:masterfrom
isidorn merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
This is a good change. Can you please just resolve the conflict with the master branch and than I will merge this in? Thanks! |
isidorn
added
the
debug
This way debug sessions sharing a single repl will all be notified about new repl elements and UI will be updated.
dgozman
force-pushed
the
on-did-change-repl-elements
branch
from
3f02f13 to
6c1cebb
Compare
Contributor
Author
|
Rebased on top of master. |
Collaborator
|
Reveiwed again, looks great. Like how we now fire from a small number of places and it seems to cover all the cases as far as I could tell. Thanks again for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way debug sessions sharing a single repl will all be notified about new repl elements and UI will be updated.
@isidorn Please take a look. This is a part of #81196 which makes sense by itself.