Compact menubar option#80900
Conversation
|
@bpasero feel free to test out this branch and review at a high level. I've also queued a build that you can play with from the branch sbatten-build-compactMenus. some code cleanup to be done around theming and css I know your feedback currently has been apprehensive to the location, but I think it is good to have everyone actually try it and see how we feel after some usage. |
|
Adding @misolori (and I would also like to hear @stevencl feedback as someone that has been designing the activity bar from the beginning with us). Current State: Some unsorted feedback:
From #17060
|
|
Regarding the menu bar control, this reuse minimizes the amount of code churn to recreate the menubar without breaking things like mnemonics, which work on windows on full screen. Otherwise I will have to rewrite some of the menubar logic to make this work properly. It is a fair debt item but I think this first approach is a good way to test various designs. Regarding the css rules, for now I can change the rules to have one for global and activities to look less hacky. If we end up keeping the menubar in the activity bar I can try to clean up the menu system to address this issue and above |
|
I am fine leaving debt items for the debt week to move this forward. What about the UX issues? |
I do agree that we should probably add some type of visual cue that this is different than the rest.
I did try this option out but it's not obvious that the logo is clickable/a menu: I think this is enough to start to get feedback on the menu and we can continue to iterate on the styling (adding hover feedback, background color, etc.). |
|
@misolori I really like the variant with the icon, can we try it out? |
|
I've made minor changes and merged master. @misolori if you want to drop in an icon or have any idea what that differentiator should be, feel free to drop it in on this branch. |
|
Notes from today's UX sync:
|





Use
window.menuBarVisibilitysetting to use the newcompactoption.