Replace Disposable[] with DisposableStore#80661
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Sep 10, 2019
solomatov:more-disposables
Merged
Replace Disposable[] with DisposableStore#80661mjbvz merged 1 commit intomicrosoft:masterfrom solomatov:more-disposables
mjbvz merged 1 commit intomicrosoft:masterfrom
solomatov:more-disposables
Conversation
mjbvz
reviewed
Sep 10, 2019
| private readonly _scrollable: ScrollableElement; | ||
| private readonly _relatedDiagnostics = new WeakMap<HTMLElement, IRelatedInformation>(); | ||
| private readonly _disposables: IDisposable[] = []; | ||
| private readonly _disposables: DisposableStore = new DisposableStore(); |
Collaborator
There was a problem hiding this comment.
[nit] Don't need to duplicate the type here
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #74250 for details.