Fix PHP in HTML style tags#80657
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Sep 15, 2019
KapitanOczywisty:patch-1
Merged
Fix PHP in HTML style tags#80657roblourens merged 2 commits intomicrosoft:masterfrom KapitanOczywisty:patch-1
roblourens merged 2 commits intomicrosoft:masterfrom
KapitanOczywisty:patch-1
Conversation
roblourens
approved these changes
Sep 15, 2019
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Wow, this is much simpler than I'd thought. Thanks!
|
|
Contributor
Author
|
This is @esemlabel job, so thanks to him :) |
Member
|
Please make sure you sign the CLA, I had to revert the change. |
Contributor
Author
|
@roblourens signed |
Member
|
Thanks! |
roblourens
added a commit
that referenced
this pull request
Sep 15, 2019
…-1"" CLA signed, bring back PR This reverts commit 0e8a10a.
This was referenced Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change will fix behavior from this comment: #33519 (comment)
This problem does not appear in
atombecause of different html grammar and imo change will be better suited here rather than upstream.There is pr on atom/language-php atom/language-php#350 however in atom this don't have any effect, because
source.cssdoes not exist and problem itself is not present.Edit:
Of course grammar have to be updated after merge.