Issue #79599 - CSS LS fails if InitializationOptions.dataPaths not set#79600
Merged
octref merged 2 commits intomicrosoft:masterfrom Aug 21, 2019
Merged
Issue #79599 - CSS LS fails if InitializationOptions.dataPaths not set#79600octref merged 2 commits intomicrosoft:masterfrom
octref merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
Thanks! I think a clearer fix would be to change: const dataPaths: string[] = params.initializationOptions.dataPaths;to const dataPaths: string[] = params.initializationOptions.dataPaths || [];Do you mind doing that instead? |
Contributor
Author
|
I'm not at all a TypeScript expert, so I'll trust your suggestion and submit a new version of the commit. |
…hs not set Signed-off-by: Mickael Istria <[email protected]>
mickaelistria
force-pushed
the
issue-79599
branch
from
b8b74fc to
558d23b
Compare
Contributor
Author
|
@octref I updated the patch as suggested. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mickael Istria [email protected]