Fix-78397 Implement case preservation in search as well#79111
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Aug 19, 2019
Merged
Fix-78397 Implement case preservation in search as well#79111roblourens merged 2 commits intomicrosoft:masterfrom
roblourens merged 2 commits intomicrosoft:masterfrom
Conversation
roblourens
requested changes
Aug 16, 2019
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Thank you, this is almost perfect! One change, please create a file in src/vs/base/common called search.ts, and create a function there that does the work to check and apply the casing patterns. Basically it should just be the lines starting with matches[0].toUpperCase() === matches[0]. We should be able to share that code between the search side and the find side. Please copy the ReplacePattern unit tests for it too. Thanks!
Contributor
Author
|
@roblourens, thanks for the review . |
… in both search side and the find side
Contributor
Author
|
Hi @roblourens , All changes done as per your review :) |
Member
|
This is great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roblourens , Here is the implementation of case preservation in search to fix #78397 .
I could not achieve this as both use a different replacePattern files.
Please review this and let me know :)
I have tested it and this works perfectly fine :)