Conversation
merge vscode from microsoft
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
This doesn't quite align with the editor find as it should only trigger a new search if the current selection is no longer valid. For example, search "foo" and get a match that's wrapped in spaces, if you toggle match whole word then in the editor it won't change anything but with this PR in the terminal it will move the selection
|
In the editor find, it will always move to the first match. If you select the second match and toggle any of the buttons, it will move to the first one. |
|
|
|
@Tyriar I believe right now it should work the same way as the editor find works. |
| const instance = this._terminalService.getActiveInstance(); | ||
| if (instance) { | ||
| if (instance.hasSelection()) { | ||
| instance.clearSelection(); |
There was a problem hiding this comment.
Huh, I thought the editor's find was more clever about this and wouldn't re-search from the beginning but apparently that's exactly how it works 👍
4 participants
#78170