Change default search to find previous#77958
Merged
Tyriar merged 5 commits intomicrosoft:masterfrom Jul 26, 2019
lramos15:change-search-behavior
Merged
Change default search to find previous#77958Tyriar merged 5 commits intomicrosoft:masterfrom lramos15:change-search-behavior
Tyriar merged 5 commits intomicrosoft:masterfrom
lramos15:change-search-behavior
Conversation
lramos15
added
the
terminal
Tyriar
requested changes
Jul 25, 2019
| this._register(this._findInput.onKeyDown((e) => { | ||
| if (e.equals(KeyCode.Enter)) { | ||
| this.find(false); | ||
| this.find(true); |
Member
There was a problem hiding this comment.
I think this actually has to happen inside terminalFindWidget as simpleFindWidget is shared with the webview as well
Member
There was a problem hiding this comment.
Also add an explanation comment where this switch is as it might be confusing if you're just reading the code
Tyriar
approved these changes
Jul 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves terminal search to follow what other terminals do and run incremental search on findPrevious with enter executing findPrevious and shift + enter executing find next. Closes #77891.