Skip to content

Make centerEditorLayout do not call layout#77743

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-76494
Aug 20, 2019
Merged

Make centerEditorLayout do not call layout#77743
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-76494

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Jul 22, 2019

Not sure if this is the right fix but it seems to not break anything. Maybe need to call layout later?
Fixes #76494.

@sandy081 sandy081 assigned bpasero, isidorn and sandy081 and unassigned sandy081, bpasero and isidorn Jul 23, 2019
@sandy081
Copy link
Member

sandy081 commented Jul 29, 2019

@jeanp413 Do not understand how this fix is related and fixes this?
Did you investigate the root cause of this issue?

@sandy081
Copy link
Member

sandy081 commented Jul 29, 2019

Sorry, read the main issue and understood the root cause. But did you check when is the layout called when not in center editor layout mode?

@sandy081 sandy081 added this to the July 2019 milestone Jul 29, 2019
@jeanp413
Copy link
Contributor Author

jeanp413 commented Jul 29, 2019

Yes, do you mean this?

vscode/src/vs/workbench/browser/workbench.ts

Lines 143 to 150 in 3889970

this.createWorkbenchLayout(instantiationService);
// Layout
this.layout();
// Restore
try {
await this.restoreWorkbench(accessor.get(IEditorService), accessor.get(IEditorGroupsService), accessor.get(IViewletService), accessor.get(IPanelService), accessor.get(ILogService), lifecycleService);

@sandy081
Copy link
Member

sandy081 commented Jul 30, 2019

Let's check with @isidorn if this change is ok or not.

@isidorn
Copy link
Collaborator

isidorn commented Jul 30, 2019

@jeanp413 thanks for your PR.
However the layout needs to be called then. The only time we can not call layout is if the layout is called afterwards.
Assigning to myself and next milestone so I can test this more.

@isidorn isidorn modified the milestones: July 2019, August 2019 Jul 30, 2019
@isidorn isidorn self-assigned this Jul 30, 2019
@isidorn
Copy link
Collaborator

isidorn commented Aug 20, 2019

On startup the layout gets called by the workbench and yes in that case it is ok that the centered editor layout does not call layout.
Since this fixes the issue it is fine to merge this PR.
@jeanp413 thanks for the PR and the fix.

@isidorn isidorn merged commit 5740357 into microsoft:master Aug 20, 2019
@jeanp413 jeanp413 deleted the fix-76494 branch August 20, 2019 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@isidorn isidorn

@sandy081 sandy081

Labels

None yet

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

Outline view doesn't remember sizing between restarts

4 participants

@jeanp413 @sandy081 @isidorn @bpasero