Skip to content

Allows terminal errors to work in the remote case#77664

Merged
Tyriar merged 7 commits intomicrosoft:masterfrom
lramos15:shell-path-error-remote
Jul 24, 2019
Merged

Allows terminal errors to work in the remote case#77664
Tyriar merged 7 commits intomicrosoft:masterfrom
lramos15:shell-path-error-remote

Conversation

@lramos15
Copy link
Member

Fixes #77414. Transmits the shellLaunchConfig from the remoteExtHost to the mainProcess so that the constructed message isn't just undefined.

@lramos15 lramos15 requested a review from Tyriar July 19, 2019 18:21
@lramos15 lramos15 added the terminal General terminal issues that don't fall under another label label Jul 19, 2019
@lramos15 lramos15 added this to the July 2019 milestone Jul 19, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once CI passes 👍

@Tyriar Tyriar merged commit 3c71e40 into microsoft:master Jul 24, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

terminal General terminal issues that don't fall under another label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal shell path error message doesn't work when default shell is used in remote

2 participants