Add a accessibility mode context key and a terminal "line navigation mode" and keybindings#77252
Merged
Add a accessibility mode context key and a terminal "line navigation mode" and keybindings#77252
Conversation
Diff: xtermjs/xterm.js@f235d70...44a843b Changes: - Parser sub-parameters/colon notation - Webgl simplify atlas/fix npe - Move sound into browser - Fix keyup event (related #76050)
bpasero
requested changes
Jul 12, 2019
Member
There was a problem hiding this comment.
@Tyriar only feedback I would have is to share the code that handles the context key in src/vs/platform/accessibility/common/accessibilityService.ts and src/vs/workbench/services/accessibility/node/accessibilityService.ts by having a common abstract base class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bpasero could you check out the changes in the accessibility services, or hand over to relevant person? I want to make sure I'm not going against the design by including the settings check in the accessibilityService.
Not merging just yet, still getting feedback on the solution from accessibility team.
Fixes #76050