Skip to content

Toggle for disabling autofocus on debugger stop#77213

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
leorochael:leorochael-optional-autofocus-on-debug
Aug 5, 2019
Merged

Toggle for disabling autofocus on debugger stop#77213
isidorn merged 1 commit intomicrosoft:masterfrom
leorochael:leorochael-optional-autofocus-on-debug

Conversation

@leorochael
Copy link
Contributor

Add boolean config to control whether the workbench window should be
focused when the debugger stops.

Fixes #23117

Co-authored-by: @joaomoreno.

Add boolean config to control whether the workbench window should be
focused when the debugger stops.

Fixes microsoft#23117

Co-authored-by: Joao Moreno <[email protected]>
@msftclas
Copy link

msftclas commented Jul 11, 2019

CLA assistant check
All CLA requirements met.

default: { configurations: [], compounds: [] },
$ref: launchSchemaId
},
'debug.autoFocusEditor': {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename this setting to
debug.focusWindowOnStop or debug.focusWindowOnBreak

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'debug.autoFocusEditor': {
'debug.focusWindowOnBreak': {

@isidorn
Copy link
Collaborator

isidorn commented Jul 29, 2019

@leorochael thanks for your PR
I have left comments directly in your commit, mostly around naming.
@weinand migh aslo have some good suggestions on the name.

@isidorn isidorn added this to the August 2019 milestone Jul 29, 2019
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 29, 2019
@isidorn
Copy link
Collaborator

isidorn commented Aug 5, 2019

@leorochael @joaomoreno Thanks for the PR.
Let's go with the name focusWindowOnBreak. Merging in

@isidorn isidorn merged commit 746e7ec into microsoft:master Aug 5, 2019
@leorochael
Copy link
Contributor Author

@isidorn, sorry for taking long to respond, but only the settings name was renamed from autoFocusEditor to focusWindowOnBreak.

The code that actually activates the window still mentions autoFocusEditor, so it's buggy:

https://github.com/microsoft/vscode/blob/master/src/vs/workbench/contrib/debug/browser/debugSession.ts#L678

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a way to control debugger stop focus changes

6 participants