Skip to content

refactor actionItem naming#73600

Merged
sbatten merged 1 commit intomicrosoft:masterfrom
sbatten:actionViewItem
May 15, 2019
Merged

refactor actionItem naming#73600
sbatten merged 1 commit intomicrosoft:masterfrom
sbatten:actionViewItem

Conversation

@sbatten
Copy link
Member

@sbatten sbatten commented May 11, 2019

After reviewing how actions become menu entries in our source code with @rebornix, we decided the naming is too confusing to keep straight. This PR is a large refactor that accomplishes the following:

  1. Rename IActionItem and all subsequent classes/interfaces to IActionViewItem. Action items are the 3rd step from Item -> item action -> action item. That transition is confusing but these objects represent how and action should be rendered and run from the UI so ActionViewItem seems appropriate.
  2. Update all variable names and comments using the above convention
  3. Remove DiffMenuItemActionItem: This is a duplicate of ContextMenu...Item
  4. Rename MenuItemActionItem => MenuEntryActionViewItem. View is added because of above. Item is changed to entry as having Item in the name twice is confusing. Do the same for ContextAwareMenuItem...

I would like to follow this refactor with some merging/restructuring of the Menu-specific action/items/viewitems to make it easier to understand. e.g. ContextAwareMenuEntryActionViewItems are used for Toolbars which are different from Menus.

@sbatten sbatten added this to the May 2019 milestone May 11, 2019
@bpasero bpasero removed their assignment May 15, 2019
@sbatten sbatten merged commit 982e7bc into microsoft:master May 15, 2019
@sbatten sbatten deleted the actionViewItem branch May 15, 2019 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants