Add setting that uses winpty for tasks#73522
Merged
Conversation
Setting defaults to true Fixes #73351
Tyriar
approved these changes
May 9, 2019
src/vs/workbench/contrib/tasks/electron-browser/task.contribution.ts
Outdated
Show resolved
Hide resolved
Member
|
I made my suggested changes and verified that conpty is only enabled when the setting is turned on. @RMacfarlane please review 🙂 |
RMacfarlane
approved these changes
May 9, 2019
src/vs/workbench/contrib/tasks/electron-browser/task.contribution.ts
Outdated
Show resolved
Hide resolved
… the ToC of settings editor
RMacfarlane
pushed a commit
that referenced
this pull request
May 9, 2019
Pull #73522 into release branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting defaults to true
Fixes #73351