Re-use isValidBasename in file picker#73332
Merged
Conversation
Member
Author
|
I'm not going to merge this until our May milestone. |
bpasero
requested changes
May 6, 2019
src/vs/base/common/extpath.ts
Outdated
| export function isValidBasename(name: string | null | undefined): boolean { | ||
| export function isValidBasename(name: string | null | undefined, isWindowsOS?: boolean): boolean { | ||
| const useWindowsRules = ((isWindowsOS === undefined) ? isWindows : isWindowsOS); | ||
| const INVALID_FILE_CHARS = useWindowsRules ? /[\\/:\*\?"<>\|]/g : /[\\/]/g; |
Member
There was a problem hiding this comment.
@alexr00 suggest to move this back out of the function and make it 2 variables WINDOWS_INVALID_FILE_CHARS and UNIX_INVALID_FILE_CHARS
src/vs/base/common/extpath.ts
Outdated
| const WINDOWS_FORBIDDEN_NAMES = /^(con|prn|aux|clock\$|nul|lpt[0-9]|com[0-9])$/i; | ||
| export function isValidBasename(name: string | null | undefined): boolean { | ||
| export function isValidBasename(name: string | null | undefined, isWindowsOS?: boolean): boolean { | ||
| const useWindowsRules = ((isWindowsOS === undefined) ? isWindows : isWindowsOS); |
Member
There was a problem hiding this comment.
@alexr00 instead of having a second "isWindows" variable here, why not make the optional parameter isWindowsOS have a default, such as:
export function isValidBasename(name: string | null | undefined, isWindowsOS = isWindows): boolean {
bpasero
approved these changes
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72866