Fix searching words in brackets in the command palette#70868
Merged
Conversation
…rks as well as whitespace
Member
|
I think this is awesome enough that we can have it now. The reason I am less worried is that we still have the list of most recently commands that shows up to the top of the list always. So even if there is a new command that matches now and was never used it would still be sorted below the one that was previously used. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies matchesWords to also split words on punctuation marks, using the default set of wordSeparators from the editor.
As is, this will affect local settings search and keybindings search too but that seems fine with me.
This could change the results that some people get for queries that they have in their muscle memory, and we don't really want to break that, but I think the benefit is large and the number of queries that it would affect is not huge. But, we need Insiders feedback and would not ship this in March.
Will add tests if we want to go this route.
Fixes #27636