Skip to content

Add showIcons and maxSuggestionsToShow settings#69942

Merged
jrieken merged 10 commits intomicrosoft:masterfrom
svipas:max-suggestions-to-show-and-icons
Mar 7, 2019
Merged

Add showIcons and maxSuggestionsToShow settings#69942
jrieken merged 10 commits intomicrosoft:masterfrom
svipas:max-suggestions-to-show-and-icons

Conversation

@svipas
Copy link
Contributor

@svipas svipas commented Mar 7, 2019

Fixes #68557

/cc @jrieken

@jrieken jrieken self-assigned this Mar 7, 2019
@jrieken jrieken added this to the March 2019 milestone Mar 7, 2019
@jrieken
Copy link
Member

jrieken commented Mar 7, 2019

lgtm - I have pushed one more commit that simplifies the applying of styles. Using the toggleClass util. Thanks, this is ready to merge. We might revisit the name of maxSuggestionsToShow, depends on team feedback.

@jrieken jrieken merged commit 3190c25 into microsoft:master Mar 7, 2019
@svipas
Copy link
Contributor Author

svipas commented Mar 7, 2019

@jrieken Thank you very much!

@svipas svipas deleted the max-suggestions-to-show-and-icons branch March 7, 2019 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to disable icons and details in suggestions

2 participants