Fix #68849 "Screencast: Some keys do not get special treatment"#69904
Merged
joaomoreno merged 3 commits intomicrosoft:masterfrom Aug 7, 2019
Merged
Fix #68849 "Screencast: Some keys do not get special treatment"#69904joaomoreno merged 3 commits intomicrosoft:masterfrom
joaomoreno merged 3 commits intomicrosoft:masterfrom
Conversation
update with origin
dyc3
force-pushed
the
fix-screencast-keys-68849
branch
from
5bbf44e to
e660bd1
Compare
adamtajti
reviewed
Mar 6, 2019
Contributor
There was a problem hiding this comment.
I think it would be enough to just add
&& !(event.keyCode === KeyCode.Backspace || event.keyCode === KeyCode.Escape)to the if at line 198 and then we can drop the logic built around previousKeyCode.
Contributor
Author
There was a problem hiding this comment.
This does slightly change the behavior, but I think this would be better.
dyc3
force-pushed
the
fix-screencast-keys-68849
branch
from
e660bd1 to
7eede97
Compare
adamtajti
approved these changes
Mar 6, 2019
Contributor
adamtajti
left a comment
adamtajti
left a comment
There was a problem hiding this comment.
I think it's good 👍 Approved from my end
Member
|
Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #68849