Updating ARM code from arm to armv7l#68250
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Feb 18, 2019
Merged
Conversation
Electron no longer publishes binary releases under the arm tag, and requires use of the armv7l tag instead. As other parts of the build system (and downstream tools) may still be relying on using the "arm" keyword, I've made it so that "armv7l" is passed to gulp-atom-electron without changing the internal code structure.
Contributor
Author
|
I've raised a similar change in gulp-atom-electron which may in fact be a better place to address this issue if you don't want to change code in the core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron no longer publishes binary releases under the arm tag, and requires use of the armv7l tag instead. This currently breaks builds for 32-bit ARM architectures.
As other parts of the build system (and downstream tools) may still be relying on using the "arm" keyword, I've made it so that "armv7l" is passed to gulp-atom-electron without changing the internal code structure.