Use jsonc.parse instead of JSON.parse when parsing tsconfig.json, fixing bug where -b flag is not activated when tsconfig.json contains comments.#67535
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Jan 30, 2019
Conversation
This fixes a problem where the `typescript` VSCode task runs `tsc` with `-p`
when it should run `-b` when `tsconfig.json` has the `"references"` property.
```js
{
"extends": "./tsconfig.app.json",
// meow
"references": [{ "path": "./tsconfig.lib.json" }]
}
```
This bug happens because while `tsconfig.json` file allows comment, the
parsing logic here uses vanilla `JSON.parse` which cannot parse comments.
This commit fixes it by using `jsonc.parse` instead.
Contributor
Author
|
Edit: It still doesn’t work because |
Collaborator
|
Makes sense. Thanks I think the argument ordering was just fixed by #67148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the
typescriptVSCode task runstscwith-pwhen it should run
-bwhentsconfig.jsonhas the"references"property.This bug happens because while
tsconfig.jsonfile allows comment, theparsing logic here uses vanilla
JSON.parsewhich cannot parse comments.This commit fixes it by using
jsonc.parseinstead.