correct message for global and snippet templates#67060
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Feb 7, 2019
gngchrs:fix/snippet_template_type_naming
Merged
correct message for global and snippet templates#67060jrieken merged 2 commits intomicrosoft:masterfrom gngchrs:fix/snippet_template_type_naming
jrieken merged 2 commits intomicrosoft:masterfrom
gngchrs:fix/snippet_template_type_naming
Conversation
jrieken
reviewed
Jan 24, 2019
|
|
||
| if (globalSnippetPicks.indexOf(pick as GlobalSnippetPick) >= 0) { | ||
| return createGlobalSnippetFile((pick as GlobalSnippetPick).uri, windowService, notificationService, fileService, opener); | ||
| return createSnippetFile('global', (pick as GlobalSnippetPick).uri, windowService, notificationService, fileService, opener); |
Member
There was a problem hiding this comment.
needs localization (nls.localize)
jrieken
reviewed
Jan 24, 2019
| return createGlobalSnippetFile((pick as GlobalSnippetPick).uri, windowService, notificationService, fileService, opener); | ||
| return createSnippetFile('global', (pick as GlobalSnippetPick).uri, windowService, notificationService, fileService, opener); | ||
| } else if (workspaceSnippetPicks.indexOf(pick as WorkspaceSnippetPick) >= 0) { | ||
| return createSnippetFile((pick as WorkspaceSnippetPick).name + ' workspace', (pick as WorkspaceSnippetPick).uri, windowService, notificationService, fileService, opener); |
Member
There was a problem hiding this comment.
also localization, maybe better with the + workspace part because it's hard to tell how this will look in various languages or with different workspace names
Member
|
@gangachris ping |
Author
Fixing this. I've been offline |
Member
|
lgtm. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating snippets, the user is asked whether they want to create a
Global,<current_workspace>or language-specific snippet. Choosing the<current_workspace>option resulted in a file withglobalPrevious
Current