fix: git.promptToSaveFilesBeforeCommit should not warn on unstaged files#66572
Closed
flurmbo wants to merge 2 commits intomicrosoft:masterfrom
flurmbo:master
Closed
fix: git.promptToSaveFilesBeforeCommit should not warn on unstaged files#66572flurmbo wants to merge 2 commits intomicrosoft:masterfrom flurmbo:master
flurmbo wants to merge 2 commits intomicrosoft:masterfrom
flurmbo:master
Conversation
|
|
Contributor
Author
|
Closed to free up my master branch, replaced by #67953 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66296. I've also changed the message strings to reflect this change. I'm not familiar with how localization is done on this project so I put that change in a separate commit.
The fix is implemented by computing unsaved documents as before and then comparing each one's path string with the paths of the objects in
repository.indexGroup.resourceStates.