Makefile grammar updating: tests are updated about the handling @, - and +#65629
Merged
alexr00 merged 1 commit intomicrosoft:masterfrom Feb 4, 2019
fadeevab:makefile-update
Merged
Makefile grammar updating: tests are updated about the handling @, - and +#65629alexr00 merged 1 commit intomicrosoft:masterfrom fadeevab:makefile-update
alexr00 merged 1 commit intomicrosoft:masterfrom
fadeevab:makefile-update
Conversation
Contributor
Author
Member
|
I've updated the grammar. I checked the rebase and it doesn't seem too bad. You should be able to rebase and push to resolve the conflicts. |
Contributor
Author
|
Ok, thank you, give me a time |
… - and +. 1. @, - and + in the beginning of recipes are colored. 2. Shell in recipes is not colored by shellscript extension anymore: improper colorizing of Makefile variables, low suitability.
Contributor
Author
|
@alexr00, Okay, eventually, makefile test is rebased, PR should be merged without conflicts. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improper colorizing of Makefile variables, low suitability.
About the pull request: the diff is mostly about the disabling a shellscript colorizing inside the Makefile, so there are joined lines like a "c": "(sed -nre 's/some regex with (group)/\1/p')". You can see echo "#" and '#'... without shellscript colorization, but it's expected: you can see the last line on the screenshot looks better with proper highlight of Makefile variables, which is desirable behavior.
Tests will work after updating the grammar from the upstream.
Shellscript coloring makes more harm than advantage: Makefile treats$(variable) with absolute high priority under processing, and shellscript extension is not able to handle those rules, confusing the developer. Also there are problems to consistently colorize $ (shell ..) and !=.
Before:
After: