strictNullChecks for macLinuxKeyboardMapper#65426
Merged
mjbvz merged 5 commits intomicrosoft:masterfrom Jan 3, 2019
Merged
Conversation
Collaborator
|
Hey looks like there's still one strict null error in that file which caused the build to fail. Some of the other merges also caused a conflict with your change |
Contributor
Author
|
@mjbvz, Fixed those issues. Looks like one of the CI builds is failing due to some unrelated error though... (502 bad gateway) |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #65233.
The change in
keyboardMapperTestUtils.tsmay actually fix strictNullChecks for a few other files as well.