Fix #65287 - Disable warning in markdown preview doesn't immediately hide the warning#65396
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Dec 19, 2018
Merged
Fix #65287 - Disable warning in markdown preview doesn't immediately hide the warning#65396mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks! This looks like the right fix to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mjbvz , This fixes #65287
this.webviewManager.refresh();was not there when the selection was made and it was just returning after toggling the setting value.So I added that line before return.
Please review this and let me know if its good :)