Enable strict null checking for snippetVariables test#65236
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Dec 18, 2018
usernamehw:strict_null_snippet_variables
Merged
Enable strict null checking for snippetVariables test#65236mjbvz merged 3 commits intomicrosoft:masterfrom usernamehw:strict_null_snippet_variables
mjbvz merged 3 commits intomicrosoft:masterfrom
usernamehw:strict_null_snippet_variables
Conversation
Collaborator
|
Thanks. I'm going to tweak the script that generates the list of eligible files to not include files like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#65233
"./vs/editor/contrib/snippet/test/snippetSession.test.ts""./vs/editor/contrib/snippet/test/snippetVariables.test.ts""./vs/editor/contrib/snippet/test/snippetParser.test.ts"You can see the build fail because of the
src/vs/editor/contrib/snippet/snippetSession.tsstrict null errors ...I enabled only
"./vs/editor/contrib/snippet/test/snippetSession.test.ts"but errors from (not a test file) appeared.