support editorHoverWidget.foreground#65170
Closed
simaosilva wants to merge 5 commits intomicrosoft:masterfrom
Closed
support editorHoverWidget.foreground#65170simaosilva wants to merge 5 commits intomicrosoft:masterfrom
simaosilva wants to merge 5 commits intomicrosoft:masterfrom
Conversation
|
|
aeschli
requested changes
Jan 3, 2019
| */ | ||
| export const editorWidgetBackground = registerColor('editorWidget.background', { dark: '#252526', light: '#F3F3F3', hc: '#0C141F' }, nls.localize('editorWidgetBackground', 'Background color of editor widgets, such as find/replace.')); | ||
| export const editorWidgetBorder = registerColor('editorWidget.border', { dark: '#454545', light: '#C8C8C8', hc: contrastBorder }, nls.localize('editorWidgetBorder', 'Border color of editor widgets. The color is only used if the widget chooses to have a border and if the color is not overridden by a widget.')); | ||
| export const editorWidgetForeground = registerColor('editorWidget.foreground', { dark: '#aaaaaa', light: '#4d4d4d', hc: '#ffbf80' }, nls.localize('editorWidgetForeground', 'Foreground color of editor widgets, such as find/replace')); |
Contributor
There was a problem hiding this comment.
I would not add that color unless it is supported by all widgets
aeschli
added
the
editor-theming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented issue #63039.
After a couple of tests, it seems to be working as intended and now it is possible to customise the hover foreground color in settings.json.
Before:
After:
Finally, selecting high_contrast theme: