Add Git log, globalConfig, and tree diff API#64826
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Jan 28, 2019
Merged
Add Git log, globalConfig, and tree diff API#64826joaomoreno merged 2 commits intomicrosoft:masterfrom
joaomoreno merged 2 commits intomicrosoft:masterfrom
Conversation
Author
|
The test failures doesn't look to have anything to do with my changes. |
joaomoreno
requested changes
Dec 20, 2018
extensions/git/src/git.ts
Outdated
| }); | ||
| } | ||
|
|
||
| async getLog(options?: GitLogOptions): Promise<Commit[]> { |
Member
There was a problem hiding this comment.
Let's call this log instead.
I would prefer if there's a default maxEntries option instead of leaving it unbounded.
extensions/git/src/git.ts
Outdated
| return []; | ||
| } | ||
|
|
||
| const entries = gitResult.stdout.split('\x00\x00'); |
Member
There was a problem hiding this comment.
This will get expensive. We should instead do a while regex exec loop and keep matching commits until we reach the end of gitResult.stdout.
extensions/git/src/git.ts
Outdated
| } | ||
|
|
||
| async diffWithHEAD(path: string): Promise<string> { | ||
| async diffWithHEAD(path?: string): Promise<string | Change[]> { |
Member
There was a problem hiding this comment.
Could we move those cool overloads also here?
diffWithHEAD(): Promise<Change[]>;
diffWithHEAD(path: string): Promise<string>;
diffWithHEAD(path?: string | undefined): Promise<string | Change[]> {
Member
|
ping @IlyaBiryukov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #62609,
cc @joaomoreno