Skip to content

Fix #64379 - SimpleFindWidget position was changed (in hidden state)#64558

Merged
Tyriar merged 1 commit intomicrosoft:masterfrom
marchenko-am:marchenko-am/fix64379
Dec 7, 2018
Merged

Fix #64379 - SimpleFindWidget position was changed (in hidden state)#64558
Tyriar merged 1 commit intomicrosoft:masterfrom
marchenko-am:marchenko-am/fix64379

Conversation

@marchenko-am
Copy link

SimpleFindWidget position was changed (in hidden state) for shadow hiding

@marchenko-am
Copy link
Author

marchenko-am commented Dec 6, 2018

There is a box shadow too long. I just changed position for hidden box and problem was solved.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll merge in after we branch off the upcoming release branch.

@marchenko-am
Copy link
Author

@Tyriar, ok, What do "branch off" mean?

@Tyriar
Copy link
Member

Tyriar commented Dec 7, 2018

@marchenko-am the release/1.30 branch was just created based off master, that's the one that will be released. Now we can merge in stuff for 1.31 🙂

@Tyriar Tyriar added this to the December 2018 milestone Dec 7, 2018
@Tyriar Tyriar merged commit 1054c55 into microsoft:master Dec 7, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants