Correcting minLength and maxLength validation messages#61556
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Oct 23, 2018
medo64:master
Merged
Correcting minLength and maxLength validation messages#61556roblourens merged 1 commit intomicrosoft:masterfrom medo64:master
roblourens merged 1 commit intomicrosoft:masterfrom
medo64:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If user violates
minLengthormaxLengthconfiguration constraint, he receives slightly incorrect message. For example, for the following setting:message displayed if only 3 characters are entered would be:
This is incorrect as comparison is than with larger-then-or-equal operator. Correct message should be:
Same principle goes for
maxLength.