Fix Markdown Preview incorrectly encodes a link#61530
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Oct 22, 2018
Merged
Conversation
For known external scheme, the customized normalizeLink method use vscode.Uri to parse and create the string representation of the link before caling the original normalizeLink method. The toString method of vscode.Uri encodes the result by default, and this is unecessary since encoding is handled by the original normalizeLink method. Calls toString method with skipEncoding option. Resolves: microsoft#60525
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For known external scheme, the customized normalizeLink method use vscode.Uri to parse and create
the string representation of the link before caling the original normalizeLink method.
The toString method of vscode.Uri encodes the result by default, and this is unecessary since encoding
is handled by the original normalizeLink method.
Calls toString method with skipEncoding option.
Resolves: #60525